Remove obsolete upload route #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsouza
reviewed
Jul 29, 2023
POSTing to `/storage/v1/b/my-bucket/o` to upload an object
is not supposed to work. The Google Cloud Storage API returns a 400
error with a response body like this:
```json
{
"error": {
"code": 400,
"message": "Uploads must be sent to the upload URL. Re-send this request to https://storage.googleapis.com/upload/storage/v1/b/my-bucket/o?uploadType=media&name=test.txt",
"errors": [
{
"message": "Uploads must be sent to the upload URL. Re-send this request to https://storage.googleapis.com/upload/storage/v1/b/my-bucket/o?uploadType=media&name=test.txt",
"domain": "global",
"reason": "wrongUrlForUpload"
}
]
}
}
```
To stay true to the GCS API, we remove support from the
`fake-gcs-server` as well.
fsouza
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSTing to
/storage/v1/b/my-bucket/oto upload an object is not supposed to work. The Google Cloud Storage API returns a 400 error with a response body like this:{ "error": { "code": 400, "message": "Uploads must be sent to the upload URL. Re-send this request to https://storage.googleapis.com/upload/storage/v1/b/my-bucket/o?uploadType=media&name=test.txt", "errors": [ { "message": "Uploads must be sent to the upload URL. Re-send this request to https://storage.googleapis.com/upload/storage/v1/b/my-bucket/o?uploadType=media&name=test.txt", "domain": "global", "reason": "wrongUrlForUpload" } ] } }To stay true to the GCS API, we remove support from the
fake-gcs-serveras well.